Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 9, 2025

Screenshot 2025-05-08 at 23 32 42

PR-Codex overview

This PR primarily introduces enhancements to the token selection process, improves error handling in the checkout flow, and adds UI components for better user interaction in the checkout process.

Detailed summary

  • Added UB_BASE_URL constant for API requests.
  • Integrated Toaster for notifications in Providers.client.tsx.
  • Enhanced TokenSelector with improved search functionality and options display.
  • Updated CheckoutLinkForm to validate input fields and manage state more effectively.
  • Added structured token management using useTokensData hook.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 9, 2025 06:33
@linear
Copy link

linear bot commented May 9, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: f6e12d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 8:47pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 9, 2025 8:47pm
login ⬜️ Skipped (Inspect) May 9, 2025 8:47pm
thirdweb_playground ⬜️ Skipped (Inspect) May 9, 2025 8:47pm
wallet-ui ⬜️ Skipped (Inspect) May 9, 2025 8:47pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 9, 2025
@gregfromstl gregfromstl requested a review from joaquim-verges May 9, 2025 06:33
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (3d7c2d4) to head (f6e12d5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6989   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         903      903           
  Lines       57934    57934           
  Branches     3970     3970           
=======================================
  Hits        31632    31632           
  Misses      26202    26202           
  Partials      100      100           
Flag Coverage Δ
packages 54.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.17 KB (0%) 1.1 s (0%) 216 ms (+86.87% 🔺) 1.3 s
thirdweb (cjs) 193.88 KB (0%) 3.9 s (0%) 416 ms (+6.21% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 74 ms (+606.67% 🔺) 187 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 42 ms (+1607.35% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.51 KB (0%) 391 ms (0%) 98 ms (+359.43% 🔺) 489 ms

id="recipient"
value={recipientAddress}
onChange={(e) => setRecipientAddress(e.target.value)}
placeholder="0x..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need ENS resolution here, easy to add in the form submit

</label>
<Input
id="token"
value={tokenAddress}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tough to make ppl enter the native token address, really needs to be a dropdown with a few popular options + custom

selecting custom then shows the address field

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super cool

couple of improvements from the comments + add name / image upload and this is really really useful

@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 17:53 Inactive
@gregfromstl gregfromstl force-pushed the greg/tool-4430-payment-links-creation-page branch from 832573a to 2792071 Compare May 9, 2025 18:09
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:19 Inactive
@gregfromstl gregfromstl force-pushed the greg/tool-4430-payment-links-creation-page branch from 1e18331 to 8b21022 Compare May 9, 2025 20:34
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:34 Inactive
@gregfromstl gregfromstl force-pushed the greg/tool-4430-payment-links-creation-page branch from 8b21022 to f6e12d5 Compare May 9, 2025 20:40
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:40 Inactive
@gregfromstl gregfromstl requested a review from joaquim-verges May 9, 2025 20:51
@gregfromstl gregfromstl merged commit 585ba2f into main May 9, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/tool-4430-payment-links-creation-page branch May 9, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants