-
Notifications
You must be signed in to change notification settings - Fork 621
Feature: Checkout link creation page #6989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6989 +/- ##
=======================================
Coverage 54.60% 54.60%
=======================================
Files 903 903
Lines 57934 57934
Branches 3970 3970
=======================================
Hits 31632 31632
Misses 26202 26202
Partials 100 100
🚀 New features to boost your workflow:
|
size-limit report 📦
|
| id="recipient" | ||
| value={recipientAddress} | ||
| onChange={(e) => setRecipientAddress(e.target.value)} | ||
| placeholder="0x..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need ENS resolution here, easy to add in the form submit
| </label> | ||
| <Input | ||
| id="token" | ||
| value={tokenAddress} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tough to make ppl enter the native token address, really needs to be a dropdown with a few popular options + custom
selecting custom then shows the address field
joaquim-verges
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is super cool
couple of improvements from the comments + add name / image upload and this is really really useful
832573a to
2792071
Compare
apps/dashboard/src/app/checkout/components/client/CheckoutLinkForm.client.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/app/checkout/components/client/CheckoutLinkForm.client.tsx
Outdated
Show resolved
Hide resolved
1e18331 to
8b21022
Compare
8b21022 to
f6e12d5
Compare
PR-Codex overview
This PR primarily introduces enhancements to the token selection process, improves error handling in the checkout flow, and adds UI components for better user interaction in the checkout process.
Detailed summary
UB_BASE_URLconstant for API requests.Toasterfor notifications inProviders.client.tsx.TokenSelectorwith improved search functionality and options display.CheckoutLinkFormto validate input fields and manage state more effectively.useTokensDatahook.